Skip to content
This repository was archived by the owner on Mar 14, 2020. It is now read-only.

[General] Completed dialogBox for alert replacement with jQuery UI Dialog.#49

Closed
xuqingkuang wants to merge 1 commit into
intel:masterfrom
xuqingkuang:dialogBox
Closed

[General] Completed dialogBox for alert replacement with jQuery UI Dialog.#49
xuqingkuang wants to merge 1 commit into
intel:masterfrom
xuqingkuang:dialogBox

Conversation

@xuqingkuang

Copy link
Copy Markdown
Contributor

dialogBox plugin provided the common popup dialogs - alert, confirm, prompt with jQuery UI dialog.

The plugin also provided the dialog customization feature, use this plugin will be able to create a form easier and the submit event handler.

For more information, please read the code.

…alog.

dialogBox plugin provided the common popup dialogs - alert, confirm, prompt with jQuery UI dialog.

The plugin also provided the dialog customization feature, use this plugin will be able to create a form easier and the submit event handler.

For more information, please read the code.
@zhizhangchen

Copy link
Copy Markdown
Contributor

dialogBox.js should also be added to FILES and README

Comment thread src/js/dialogBox.js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better not put dialogBox into jQuery's namespace, as it depends on jQuery-UI

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jQuery UI version is buggy, See - https://github.com/xuqingkuang/jquery-ui-dialogbox

@zhizhangchen

Copy link
Copy Markdown
Contributor

Basically, I think this plugin is too complicated for simply replacing alert(). Please try to replace confirm() function in rib using this plugin.

Comment thread src/js/dialogBox.js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you define this class?

@zhizhangchen

Copy link
Copy Markdown
Contributor

Replaced by #104

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants